Re: [RFC PATCH] Add WEBDAV timeout to http-fetch.
- From
Junio C Hamano <junkio@cox.net>
- Date
- Oct 8, 2006, 04:52 UTC
- Message-ID
- <7vbqonpfyl.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.63.0610080034490.14200@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 5 quoted lines
> Actually, I do not think that anybody in her right mind would set this to > different values for different repos or servers. > > I _know_ that if I hit that very problem, the next thing I'd do is set the > timeout to 5 seconds _globally_.
Let's step back a bit.
The DAV request in question the one to remote_ls() in http-fetch.c, which tries to read directly from objects/pack/ instead of using objects/info/packs, and it does not matter if DAV request fails because it would fall back to non-DAV anyway.
Using DAV, if it works with the server, has the advantage of not having to keep objects/info/packs up-to-date from repository owner's point of view. But the repository owner ends up keeping up-to-date as a side effect of keeping info/refs up-to-date anyway (as I do not see a code to read that information over DAV), so there is no point doing this over DAV in practice.
Perhaps we should remove call to remote_ls() from fetch_indices() unconditionally, not just protected with NO_EXPAT and be done with it?