Re: [ANNOUNCE] GIT 1.4.3
- From
Junio C Hamano <junkio@cox.net>
- Date
- Oct 21, 2006, 05:29 UTC
- Message-ID
- <7vbqo6i6da.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20061021021235.GA29920@ftp.linux.org.uk>
Al Viro <viro@ftp.linux.org.uk> writes:
> Speaking of irritations... There is a major (and AFAICS fixable) > suckitude in git-cherry. Basically, what it does is...
Yeah, that sucks big time. I never realized there are people who still are using it, though. git-format-patch used to use it, but the version was retired exactly five months ago, and there is no in-tree users anymore.
I guess we could separate out the revision filtering logic in builtin-log.c:cmd_format_patch() and implement git-cherry as a new built-in.