Re: [PATCH] Increase length of function name buffer

From: Junio C Hamano <junkio@cox.net>
Date: Nov 23, 2006, 20:53 UTC
Message-ID: <7vbqmxkhpk.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200611231005.17859.andyparkins@gmail.com>

Andy Parkins <andyparkins@gmail.com> writes:

Show 9 quoted lines

> In xemit.c:xdl_emit_diff() a buffer for showing the function name as
> commentary is allocated; this buffer was 40 characters.  This is a bit
> small; particularly for C++ function names where there is often an
> identical prefix (like void LongNamespace::LongClassName) on multiple
> functions, which makes the context the same everywhere.  In other words
> the context is useless.  This patch increases that buffer to 80
> characters - which may still not be enough, but is better.
>
> Signed-off-by: Andy Parkins <andyparkins@gmail.com>

I agree this is a good problem to address.

I wonder however which is easier to read, a loooong heading line as you do in this patch, or "...TailOfVeryLongClassName::method" that still fits on a single line without terminal line-wrapping. Especially with our default settings that runs "less" with -S to truncate the right hand side of a long line, truncating at the top (instead of at the tail as we currently do) might be easier to read.

Not rejecting your implementation and asking to change the patch; asking for opinions from the list.