Re: [PATCH] Correct dir.c to compile on Solaris 9
- From
Junio C Hamano <junkio@cox.net>
- Date
- Apr 15, 2007, 22:48 UTC
- Message-ID
- <7vbqhp2qzv.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <200704152354.55097.robin.rosenberg.lists@dewire.com>
Robin Rosenberg <robin.rosenberg.lists@dewire.com> writes:
Show 27 quoted lines
> The table lookup *is* faster (meastured), but that doesn't make a big difference
> on the total CPU used. The muliple-case-per line thing (both versions, however makes is hard
> to read.
>
> -- robin
>
> diff --git a/dir.c b/dir.c
> index 7426fde..0780f23 100644
> --- a/dir.c
> +++ b/dir.c
> @@ -423,12 +423,22 @@ static int cmp_name(const void *p1, const void *p2)
> */
> static int simple_length(const char *match)
> {
> - const char special[256] = {
> - [0] = 1, ['?'] = 1,
> - ['\\'] = 1, ['*'] = 1,
> - ['['] = 1
> - };
> int len = -1;
> + static const char special[256] = {
> + 1,0,0,0,0,0,0,0, /* nul */
> + 0,0,0,0,0,0,0,0,
> + 0,0,0,0,0,0,0,0,
> + 0,0,0,0,0,0,0,0,
> + 0,0,0,0,0,0,0,0,
> + 0,0,1,0,0,0,0,0, /* * */I wonder if folding this into ctype.c::sane_ctype[] is an option...