git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] git-submodule: rename shell functions for consistency

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 16, 2008, 20:08 UTC
Message-ID
<7vbq7lpm78.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<7bfdc29a0801151826u2218f825ga8100b1cc9fa8b2@mail.gmail.com>
"Imran M Yousuf" <imyousuf@gmail.com> writes:
> Thanks Junio for showing how it should be done. Due to some
> pre-scheduled appointment I was unavailable yesterday evening and thus
> was neither able to reply nor resubmit the changes.

Well, I did not show how it _should_ be done. That series was merely an illustration of how I _think_ it should look like. I did not test it, I do not know if it introduced new bugs, and most importantly I do not know if it fulfills what you intended to achieve with your patch.

In other words, I just tried to turn the table around. Instead of me and others commenting on your patch saying "I do not like this" piecemeal, now you have something you can comment on. You can say the whole range of things from "I tested this and it is what I want", "I like the general concept but I found this and that bug and here is a fix", to "This is much worse than what I proposed and here is why."

Previous: Imran M YousufNext: Junio C Hamano
Message 5 of 7 in “- git submodule subcommand parsing modified.”
  1. - git submodule subcommand parsing modified.imyousuf@gmail.com, Jan 14, 2008
  2. Junio C HamanoJan 15, 2008
  3. 1/3 git-submodule: rename shell functions for consistencyJunio C Hamano, Jan 15, 2008
  4. Imran M YousufJan 16, 2008
  5. Junio C HamanoJan 16, 2008
  6. 2/3 git-submodule: fix subcommand parserJunio C Hamano, Jan 15, 2008
  7. 3/3 git-submodule: add test for the subcommand parser fixJunio C Hamano, Jan 15, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.