git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/7] Use 'printf %s $x' notation in t5401

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 31, 2008, 01:16 UTC
Message-ID
<7vbq72hjzo.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080130064845.GR24004@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> writes:
Show 18 quoted lines
> Junio C Hamano <gitster@pobox.com> wrote:
>> ...
>> Do you really mean this? "printf %s 1 2 3" writes "123" without
>> terminating LF.  You seem to check only for size but to be
>> reusable you might want to use something like:
> 
> The only thing we care about is was there args or not to the hook.
> I probably could do that test differently, like say:
>
> 	echo $# >$GIT_DIR/pre-receive.args
>
> and then test that the file contains "0" instead of looking for it to
> be empty.  Not sure why I didn't write it that way in the beginning.
>
>> 	printf '%s\n' "$@"
>
> Eh.  Since all we care is that the argument count is 0 we probably
> should be looking at $# and calling it a day.

I'll apply as-is, but once you break the code that calls pre-receive hook in such a way that it sends unexpected arguments, you'd thank me for suggesting to print the arguments separately while debugging the problem with the test script.

Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 4 of 5 in “Use 'printf %s $x' notation in t5401”
  1. 1/7 Use 'printf %s $x' notation in t5401Shawn O. Pearce, Jan 30, 2008
  2. Junio C HamanoJan 30, 2008
  3. Shawn O. PearceJan 30, 2008
  4. Junio C HamanoJan 31, 2008
  5. Shawn O. PearceJan 31, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.