Re: [updated PATCH] Same default as cvsimport when using --use-log-author

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 27, 2008, 20:47 UTC
Message-ID: <7vbq3vf2k4.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080427173246.10023.5687.stgit@aristoteles.cuci.nl>

"Stephen R. van den Berg" <srb@cuci.nl> writes:

> git-svn supports an experimental option --use-log-author which currently
> results in:
>
> Author: foobaruser <unknown>

I have a question about this.  Is the "<unknown> coming from...

Show 13 quoted lines

> This patches harmonises the result with cvsimport, and makes
> git-svn --use-log-author produce:
>
> Author: foobaruser <foobaruser>
> ...
> diff --git a/git-svn.perl b/git-svn.perl
> index b151049..846e739 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -2434,6 +2434,9 @@ sub make_log_entry {
>  		} else {
>  			($name, $email) = ($name_field, 'unknown');
>  		}

... this 'unknown' we see here?

> +	        if (!defined $email) {
> +		    $email = $name;
> +	        }
>  	}

I would think not -- if that is the case, the codepath you added as a fix would not trigger. Which means in some other cases, the 'unknown' we see above in the context also still happens. Is it a good thing? Maybe we would also want to make it consistently do "somebody <somebody>" instead, by doing...

	} else {
		$name = $name_field;
	}
        if (!defined $email) {
	    $email = $name;
        }