Re: [PATCH?] Fix 'git show' on signed tag of signed tag of commit

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 1, 2008, 23:55 UTC
Message-ID: <7vbq1hkvmm.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1214905624-29517-1-git-send-email-trast@student.ethz.ch>

Thomas Rast <trast@student.ethz.ch> writes:

Show 14 quoted lines

> The cmd_show loop resolves tags by showing them, then pointing the
> object to the 'tagged' member.  However, this object is not fully
> initialized; it only contains the SHA1.  (This resulted in a segfault
> if there were two levels of tags.)  We apply parse_object to get a
> full object.
>
> Noticed by Kalle Olavi Niemitalo on IRC.
>
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> ---
>
> I'm not 100% sure this is the right fix; I just had a quick stab at
> the code, made a fix and tested it.  It probably leaks memory too, not
> sure if this is a problem.

The code looks good. It should not have been accessing the object without making sure it has been parsed.

And it's not a leak. Once you instantiate "struct object" derived class, we hold onto it (at least to its skeleton).

Thanks.