Re: [BUG] commit walk machinery is dangerous !

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 14, 2008, 21:55 UTC
Message-ID: <7vbq10f7wr.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.1.10.0807141641110.12484@xanadu.home>

Nicolas Pitre <nico@cam.org> writes:

Show 7 quoted lines

> However this time a corruption turned up and exposed what I think is a 
> major flaw in git's error checking.  To demonstrate it, I created the 
> following test case.  Turning the error() into a die() on line 772 of 
> commit.c makes this test pass but I don't know if this is the 
> appropriate fix (e.g. some attempt to parse non existing commits could 
> be valid usage, etc.).  Note this is critical only for git versions 
> later than commit 8eca0b47ff15.

Which probably means we should revert that commit as faulty? IIRC, before that commit we did check and error out correctly but you loosened the check to introduce "a major flaw" with that commit.

$ for b in maint master next pu
  do
      echo -n $b; git cat-file blob $b:commit.c | wc -l
  done
maint 672
master 672
next 779
pu 789

Hmph...