git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] checkout: Don't crash when switching away from an invalid branch.

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 7, 2008, 23:06 UTC
Message-ID
<7vbpwrf85x.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<87od0r9nnj.fsf@wine.dyndns.org>
Alexandre Julliard <julliard@winehq.org> writes:
Show 8 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> ...
>> Why not
>> 		old_desc ? old_desc : "(invalid)"
>> ?
>
> IMO it looks more friendly to not display a branch that doesn't exist,
> rather than printing something like (invalid) or (null).

Actually I think it is a good idea to remind that you were in a funny state.

For that matter, dying without removing the trace of that funny state might be even preferrable if you need to do postmortem to figure out why you got into such a funny state to begin with, but not everybody uses git to debug git. I think Dscho's suggestion is a reasonable middle ground.

Previous: Alexandre JulliardNext: Alexandre Julliard
Message 4 of 5 in “checkout: Don't crash when switching away from an invalid branch.”
  1. checkout: Don't crash when switching away from an invalid branch.Alexandre Julliard, Nov 7, 2008
  2. Johannes SchindelinNov 7, 2008
  3. Alexandre JulliardNov 7, 2008
  4. Junio C HamanoNov 7, 2008
  5. Alexandre JulliardNov 8, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.