Re: [PATCH 2/3] diff: allow turning on textconv explicitly for plumbing

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 8, 2008, 04:08 UTC
Message-ID: <7vbpvn9um4.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7vfxkz9v8f.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 15 quoted lines

> Jeff King <peff@peff.net> writes:
>
>> I know this is not strictly a bugfix and we are in -rc, but:
>>
>>   1. It is an enhancement to a previously unreleased feature, and
>>      shouldn't affect anything outside of that.
>>
>>   2. It affects the scripting interface to textconv, so I would like to
>>      get it in before textconv is ever released so that it is always the
>>      "right way" to turn text conversion off or on.
>
> I'd agree with #1, especially if you said "doesn't" instead of
> "shouldn't".
>
> But I am not 100% sure if the scripting part is "the right way".

But I'll apply them anyway.