git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git log: avoid segfault with --all-match

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 18, 2009, 18:33 UTC
Message-ID
<7vbpryfzpb.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1237399576-27323-1-git-send-email-barra_cuda@katamail.com>
Michele Ballabio <barra_cuda@katamail.com> writes:
Show 11 quoted lines
> Avoid a segfault when the command
>
> 	git log --all-match
>
> was issued.
>
> Signed-off-by: Michele Ballabio <barra_cuda@katamail.com>
> ---
>
> Not sure if this is the right fix, nor if it would be better a
> warning or an error.

I think ignoring it makes sense; you could alias "git log --all-match" to something like "git lg", and when no grepping option appears it will still work.

I'd add s/was issued./was issued, by ignoring the option/; or something like that, though.

Previous: Michele BallabioNext: Michele Ballabio
Message 2 of 3 in “git log: avoid segfault with --all-match”
  1. git log: avoid segfault with --all-matchMichele Ballabio, Mar 18, 2009
  2. Junio C HamanoMar 18, 2009
  3. git log: avoid segfault with --all-matchMichele Ballabio, Mar 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.