Re: [RFC/PATCH] rebase: add -x option to record original commit name

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 6, 2010, 04:43 UTC
Message-ID: <7vbpg3dldq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <76718491002052018s324747ecj31963b493868dbbd@mail.gmail.com>

Jay Soffian <jaysoffian@gmail.com> writes:

Show 8 quoted lines

> Since there is a difference of opinion here, how about this proposal:
>
> 1) We keep -x in cherry-pick
>
> 2) I convince you to add my -x patch to rebase.sh (hmm, how to do that?) :-)
>
> 3) We add a -X option to both cherry-pick and rebase.sh that records
> in the notes instead of in the log message.

How could that be a counterproposal to a deprecation of -x and adding hooks as a replacement, as a solution to more general issues?

Show 11 quoted lines

>> I ended up using this hacky script for that.  It finds the svn uuid from
>> the metadata file, and then finds ".rev_map.$uuid" files from all over the
>> place to see if any of them contains a record that points at the git
>> commit I am interested in.
>>
>> I really wish "git svn" has a built-in way to do something like that;
>> perhaps I didn't look hard enough.
>
> Is git svn find-rev not what you want? (Caveat, it doesn't seem to
> work for me, but it's claimed description seems to be what you're
> asking for.)

Maybe, but it calls cmt_metadata() which is "grep ^git-svn-id:" of the commit object, so we know why it doesn't X-<.