git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: 'git status' on NFS performance regression in 1.7.0

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 17, 2010, 22:03 UTC
Message-ID
<7vbpfncyer.fsf@alter.siamese.dyndns.org>
In-Reply-To
<885649361002171335r74295d34l9a5ed9557059dbc6@mail.gmail.com>
James Pickens <jepicken@gmail.com> writes:
> I'm not sure how to interpret the "subtle breakage" comment with the
> winking smiley.  Do you mean that preload_index in 1.7.0 is not well tested
> and may be broken?  FWIW, I didn't notice any breakage, but I didn't do
> much testing.

The new "status" codepath is different from "commit --dry-run" codepath that was used by "git status" in 1.6.6 series. This old codepath has been used extensibly with preloaded index and is continued to be used when you run "git commit" with various options. It is not preload-index that could be subtly broken.

However, nobody used the new "status" codepath with preloaded index, and I haven't thought things through if anything we are doing in that codepath is incompatible with preloaded index in some way.

By the way, the argument to read_cache_preload() should be s.pathspec, not NULL, I think.

Thanks.
Previous: James PickensNext: Peter Krefting
Message 5 of 6 in “'git status' on NFS performance regression in 1.7.0”
  1. James PickensFeb 17, 2010
  2. Junio C HamanoFeb 17, 2010
  3. Junio C HamanoFeb 17, 2010
  4. James PickensFeb 17, 2010
  5. Junio C HamanoFeb 17, 2010
  6. Peter KreftingFeb 18, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.