Re: [RFD] Deepen the git directory structure a bit.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 18, 2010, 20:24 UTC
- Message-ID
- <7vbpfm9tst.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <alpine.LFD.2.00.1002181010590.4141@localhost.localdomain>
Linus Torvalds <torvalds@linux-foundation.org> writes:
Show 6 quoted lines
> I think this coul probably be done differently (I'm not proud of that ugly > '-I. -Ibuiltin' addition to the CFLAGS, for example), and I think there > are _other_ things we could also try to do to move files into > subdirectories, but this was a fairly easy thing to basically script. > > What do people think?
I personally like the general direction you are going. One minor detail I do not know about is whether to move "builtin.h" with others, or leave it at the top. Also I don't particularly find "-I. -Ibuiltin/" ugly. It would make sense to use "-I." and rewrite our '#include "xyzzy.h"' into '#include <xyzzy.h>' even if we were not doing this change.