Re: [PATCH 2/2] templates/hooks--*: don't refer to contrib hooks

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 26, 2011, 17:52 UTC
Message-ID: <7vbou742eg.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110926125932.27854.qmail@804c778e7e6607.315fe32.mid.smarden.org>

Gerrit Pape <pape@smarden.org> writes:

Show 21 quoted lines

> Simplify the sample post-receive hook to not refer to some location of a
> contrib hook that might be installed in different locations on different
> systems.  Instead simply provide a sample file that does nothing just as
> the post-commit sample hook.
>
> Signed-off-by: Gerrit Pape <pape@smarden.org>
> ---
>  templates/hooks--post-receive.sample |   12 ++----------
>  1 files changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/templates/hooks--post-receive.sample b/templates/hooks--post-receive.sample
> index 7a83e17..5b1771f 100755
> --- a/templates/hooks--post-receive.sample
> +++ b/templates/hooks--post-receive.sample
> @@ -2,14 +2,6 @@
>  #
>  # An example hook script for the "post-receive" event.
>  #
> +# To enable this hook, rename this file to "post-receive".
>  
> +: Nothing

I removed the "-" lines above. Looking at the result, I really have to wonder if it makes much sense to keep the file here. It is not even an example anymore, and the user does not gain anything by enabling it, following the suggestion.

Let's instead remove the file altogether, Ok?