git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] send-email: add extra safetly in address sanitazion

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 5, 2012, 21:52 UTC
Message-ID
<7vbopdeyne.fsf@alter.siamese.dyndns.org>
In-Reply-To
<87sjipxe5u.fsf@thomas.inf.ethz.ch>
Thomas Rast <trast@inf.ethz.ch> writes:
Show 9 quoted lines
> Am I the only one who stared at this for ten seconds, only to then
> realize that there is no sanitizing whatsoever going on here?
>
>>   'Foo Bar <foo@bar.com>>' -> 'Foo Bar <foo@bar.com>'
>>   '"Foo Bar" <foo@bar.com>>' -> '"Foo Bar" <foo@bar.com>'
>>   '<foo@bar.com>>' -> 'foo@bar.com'
>
> All of these are the same underlying issue.  Does your patch fix any
> other malformed addresses, or just this particular type?

Just this particular type, as long as the code handles it correctly, would be better than nothing.

On the recieving end in mailinfo, I think we also support
	gitster@pobox.com (Junio C Hamano)

although it does not seem to be used by many people these days (the only one I can remember seeing on this list was merlyn), so we may want to be a bit more consistent between sending and receiving end, though.

Previous: Junio C Hamano
Message 7 of 7 in “send-email: add extra safetly in address sanitazion”
  1. send-email: add extra safetly in address sanitazionFelipe Contreras, Feb 4, 2012
  2. Thomas RastFeb 5, 2012
  3. Felipe ContrerasFeb 5, 2012
  4. Thomas RastFeb 5, 2012
  5. Felipe ContrerasFeb 6, 2012
  6. Junio C HamanoFeb 6, 2012
  7. Junio C HamanoFeb 5, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.