Re: [PATCH v3 2/4] http: try http_proxy env var when http.proxy config option is not set
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 6, 2012, 15:58 UTC
- Message-ID
- <7vboo9vhzf.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <4F560196.8070500@seap.minhap.es>
Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es> writes:
> As I said in the commit message, in that cases a 407 error will be > returned from those applications, because curl will not ask you for > the password,...
If that is the case, people cannot write their username in the http_proxy environment variable---otherwise they will not be able to use these applications. If people do not have username in that environment, this patch will not help us.
I think I saw you and Peff discussing down-thread that this patch may not be needed, so if that is the case it is good---we won't have to worry about it.
Thanks.