git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] build: do not automatically reconfigure unless configure.ac changed

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 2, 2013, 20:25 UTC
Message-ID
<7vbod72uze.fsf@alter.siamese.dyndns.org>
In-Reply-To
<50E48BF6.2020900@gmail.com>
Stefano Lattarini <stefano.lattarini@gmail.com> writes:
Show 15 quoted lines
>>  ifdef AUTOCONFIGURED
>> -config.status: configure
>> -	$(QUIET_GEN)if test -f config.status; then \
>> +# We avoid depending on 'configure' here, because it gets rebuilt
>> +# every time GIT-VERSION-FILE is modified, only to update the embedded
>> +# version number string, which config.status does not care about.
>>
> Alas, config.status *do* care about it, in that the '@PACKAGE_VERSION@',
> '@PACKAGE_STRING@' and '@DEFS@' substitutions are affected by what is
> hard-coded in configure as the version number [1].  But if we do not
> use those substitutions in any of our files (and I believe we don't),
> then *we* can happily not care about the configure embedded version
> number string, and thus avoid the extra configure runs.  Phew.
>
>  [1] Yes, this is a mess.  We know.  Sorry!

Heh. Should we warn against the use of these symbols somewhere in configure.ac, perhaps, then?

Previous: Stefano LattariniNext: Stefano Lattarini
Message 11 of 13 in “Makefile dependency from 'configure' to 'GIT-VERSION-FILE'”
  1. Martin von ZweigbergkJan 2, 2013
  2. Jonathan NiederJan 2, 2013
  3. Martin von ZweigbergkJan 2, 2013
  4. build: do not automatically reconfigure unless configure.ac changedJonathan Nieder, Jan 2, 2013
  5. Jeff KingJan 2, 2013
  6. Jonathan NiederJan 2, 2013
  7. Stefano LattariniJan 2, 2013
  8. Junio C HamanoJan 2, 2013
  9. Martin von ZweigbergkJan 2, 2013
  10. Stefano LattariniJan 2, 2013
  11. Junio C HamanoJan 2, 2013
  12. Stefano LattariniJan 2, 2013
  13. Jonathan NiederJan 2, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.