Re: [PATCH v4] config: add support for http.<url>.* settings

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 12, 2013, 18:48 UTC
Message-ID: <7vbo67limv.fsf@alter.siamese.dyndns.org>
In-Reply-To: <a2ef80fd50c466e5c69726a1968f8ad@f74d39fa044aa309eaea14b9f57fe79>

"Kyle J. McKay" <mackyle@gmail.com> writes:

Show 7 quoted lines

> +	if (!strcmp("sslcertpasswordprotected", key)) {
> +		if (check_matched_len(opt_passwd_req, matchlen))
> +			return 0;
>  		if (git_config_bool(var, value))
>  			ssl_cert_password_required = 1;
>  		return 0;
>  	}

This is not a new problem, but I think the existing code is wrong. There is no way to countermand an earlier

	[http]
        	sslcertpasswordprotected

in a more generic configuration file with

	[http]
        	sslcertpasswordprotected = no

in a repository specific configuration file.

Perhaps we should fix it as a preparatory patch (1/2) before the main "feature addition" patch.

Show 7 quoted lines

> -	if (!strcmp("http.ssltry", var)) {
> +	if (!strcmp("ssltry", key)) {
> +		if (check_matched_len(opt_ssl_try, matchlen))
> +			return 0;
>  		curl_ssl_try = git_config_bool(var, value);
>  		return 0;
>  	}