git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-rev-list: Don't die on a bad tag

From
Junio C Hamano <junkio@cox.net>
Date
Aug 27, 2005, 09:14 UTC
Message-ID
<7vacj3vizy.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<4310217D.80408@tuxrocks.com>
Frank Sorenson <frank@tuxrocks.com> writes:
Show 7 quoted lines
> The current cogito tree contains an invalid tag
> (junio-gpg-pub => 0918385dbd9656cab0d1d81ba7453d49bbc16250), and
> git-repack-script (and probably others) will die when git-rev-list
> tries to dump the objects.  This patch changes it to complain, but
> continue.
>
> Signed-off-by: Frank Sorenson <frank@tuxrocks.com>
I think this patch is wrong.

The check you are disabling is to see if the repository contains an object that a tag refers to, and the user wanted to slurp the tag, along with whatever thing it refers to, so barfing and dying is the only right thing to do.

The repository does not have the object the tag points at. IOW, the repository is not fsck clean.

If it bothers you either you could drop that tag from cogito repository (because there would not be anything that is signed by _my_ public key anyway), or borrow the object from git.git repository.

Previous: Frank Sorenson
Message 2 of 2 in “git-rev-list: Don't die on a bad tag”
  1. git-rev-list: Don't die on a bad tagFrank Sorenson, Aug 27, 2005
  2. Junio C HamanoAug 27, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.