Re: git 0.99.7b doesn't build on Cygwin

From: Junio C Hamano <junkio@cox.net>
Date: Sep 24, 2005, 03:04 UTC
Message-ID: <7vaci36u95.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.58.0509231935360.3308@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

Show 5 quoted lines

> Looking a bit closer at the diff() usage, I actually think that we could 
> move the fork() closer to the exec - we'd just have to move it _into_ all 
> the different cases (ie you'd have two different fork() calls: one for 
> the "builtin" case, one for the external pgm case, but then the child in 
> both cases would be very simple).

Looking back at what I did in the diff.c, I actually think the part near fork() is a total crap ;-).

Originally I intended to do more work in the child process (this is totally opposite of what is being proposed now), for example running prepare_temp_file() after child forked, so that the parent process does not have to worry about using memory for expanded blob to be written out to the temporary file and then later forgetting to free it ;-), but it seems the parent is doing more work than I intended to. I honestly think that the part of the code is ancient enough to deserve a major facelift.