Re: ls-files and read-tree need core.filemode

From: Junio C Hamano <junkio@cox.net>
Date: Nov 8, 2005, 08:55 UTC
Message-ID: <7vacgfldry.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <81b0412b0511080023k1384dc26j944e9a07987be436@mail.gmail.com>

Alex Riesen <raa.lkml@gmail.com> writes:

> As usual, sorry for attachments.

Attachments are a bit cumbersome to quote but otherwise OK, at least for me. Linus never admits it, but I am hoping that he is having a bit easier time applying e-mailed patches ever since rudimentally MIME attachment handling was added.

However, please note that git-mailinfo which splits a piece of e-mail into metainformation and patch part takes commit log material only from the main message part, so having this one-line explanation inside attachment is like having it under the three-dash line.

>>    ls-files needs default config to ignore filemode on cygwin

I think this case you meant to do that; your main message part was almost fine as is, as a commit log message (except perhaps the initial "Hi," part ;-).

Show 5 quoted lines

>>diff --git a/ls-files.c b/ls-files.c
>>--- a/ls-files.c
>>+++ b/ls-files.c
>>@@ -569,10 +569,11 @@ int main(int argc, const char **argv)
>> 	argv0 = *argv;

I wonder what this thing is, though. I sense that usage() cleanup patch that makes programs state their names semi-automatically is coming...