Re: [PATCH] upload-pack: fix timeout in create_pack_file

From: Junio C Hamano <junkio@cox.net>
Date: Jul 24, 2006, 07:55 UTC
Message-ID: <7vac6ze8t5.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <E1G4uZw-0006vZ-VO@moooo.ath.cx>

Matthias Lederhofer <matled@gmx.net> writes:

Show 11 quoted lines

> Junio C Hamano <junkio@cox.net> wrote:
>
>> My gut feeling is that your patch would be fine as is (have you
>> tried and confirmed that it helps cases other than slow
>> clients?)
> ... I tried a server with --timeout=600 and a client
> that cannot download the whole pack file in 10 minutes.  Without the
> patch the server closes the connection, with this patch it works.
> Additionally I tried it with a client reading so slow that the server
> was blocked for more than --timeout seconds, then the server closes
> the connection too (this is more or less the DoS case).

Thanks, that's all I wanted to know.  Let's have it.