Re: [PATCH] apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches

From: Junio C Hamano <junkio@cox.net>
Date: Sep 17, 2006, 08:49 UTC
Message-ID: <7vac4y7u8n.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <eej12j$36t$2@sea.gmane.org>

Jakub Narebski <jnareb@gmail.com> writes:

Show 10 quoted lines

> Junio C Hamano wrote:
>
>> This adds a new flag, --unified-zero, to allow bypassing these
>> checks.  If you are in control of the patch generation process,
>> you should not use --unified=0 patch and fix it up with this
>> flag; rather you should try work with a patch with context.  But
>> if all you have to work with is a patch without context, this
>> flag may come handy as the last resort.
>
> Doesn't -C0 option to git-apply bypass those checks?

Only the head/tail anchor check, but not the creation/deletion check.

Also -CNUM's meaning is "you are allowed to reduce context down to only this many lines if you need to (but you do not have to if you can find the right match with context recorded in the patch)" not "what I am feeding you is a context-free patch so loosen sanity checks", so it does not make much sense to overload the flag with such a new meaning (if that is what you are implying, that is).