Re: [RFC][PATCH] gitweb: Make the Git logo link target to point to the homepage

From: Junio C Hamano <junkio@cox.net>
Date: Sep 23, 2006, 20:46 UTC
Message-ID: <7vac4qs43g.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <ef43do$fm1$1@sea.gmane.org>

Jakub Narebski <jnareb@gmail.com> writes:

Show 9 quoted lines

> Junio C Hamano wrote:
>
>> -             "<a href=\"http://www.kernel.org/pub/software/scm/git/docs/\" title=\"git documentation\">" .
>> +             "<a href=\"" . esc_html($githelp_url) .
>> +             "\" title=\"" . esc_html($githelp_label) .
>> +             "\">" .
>
> Why not use $cgi->a_begin({-href=>esc_param($githelp_url), -title=>$githelp_label});
> or just plain $cgi->a and $cgi->img?

Be my guest and send in a proper patch please.

I was merely demonstrating my preference on how definition of default values and actual use of them are separated.