Re: [PATCH] gitk: pass --no-left-right to rev-list

From: Junio C Hamano <junkio@cox.net>
Date: Dec 19, 2006, 10:28 UTC
Message-ID: <7vac1krxgw.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20061219100534.GA9206@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 5 quoted lines

> I think there are three fixes:
>   1. this patch (avoid using left-right)
>   2. gitk can detect and parse the new format
>   3. revert automatic use of left-right
> The third makes the most sense to me.

1. has the problem that it requires the version of Porcelains
and the core to be tightly linked.  2. is nice but unnecessary
burden in the short term.  3. does not break things for anybody,
but if left-right output is useful on the terminal, it burdens
the end-user typing from the command line.

So in the longer term, 2 is probably slightly more preferrable, but my philosophy is "do not change anything unless absolutely necessary", so 3 is also sensible, at least in the short term.

Thanks for catching this quickly, before it hit the master. Let's revert 57612319.