git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/5] merge-recursive: handle D/F conflict case more carefully.

From
Junio C Hamano <junkio@cox.net>
Date
Apr 10, 2007, 18:20 UTC
Message-ID
<7vabxgw0pd.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<81b0412b0704100140g7684e128g75c986c213ac9d0f@mail.gmail.com>
"Alex Riesen" <raa.lkml@gmail.com> writes:
Show 22 quoted lines
> On 4/9/07, Junio C Hamano <junkio@cox.net> wrote:
>> Alex Riesen <raa.lkml@gmail.com> writes:
>>
>> > Junio C Hamano, Sat, Apr 07, 2007 16:42:55 +0200:
>> >> +                    if (unlink(path)) {
>> >> +                            if (errno == EISDIR) {
>> >> +                                    /* something else exists */
>> >> +                                    error(msg, path, ": perhaps a D/F conflict?");
>> >
>> > isn't this one an F/D conflict?
>>
>> Yes, as I said in a separate message, the current D/F detector
>> code in merge-recursive does not catch this case in t3030 test
>> and comes to this codepath to write it out:
>>
>
> I mean, maybe the error could be spelled differently:
> ": perhaps an F/D conflict?"
> Right now we have two exactly the same errors,
> as seen on the output. The messages refer to different
> conflicts, though. It is usually useful to know what is really
> going on.

Perhaps, but I think the bigger issue is that existing D/F or F/D conflict detection is simply buggy, and this patch shouldn't be needed if they were working correctly.

Previous: Alex Riesen
Message 5 of 5 in “merge-recursive: handle D/F conflict case more carefully.”
  1. 4/5 merge-recursive: handle D/F conflict case more carefully.Junio C Hamano, Apr 7, 2007
  2. Alex RiesenApr 9, 2007
  3. Junio C HamanoApr 9, 2007
  4. Alex RiesenApr 10, 2007
  5. Junio C HamanoApr 10, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.