git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: Fix few 'use of undefined value' warnings

From
Junio C Hamano <junkio@cox.net>
Date
May 17, 2007, 04:05 UTC
Message-ID
<7vabw4ccy5.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20070517013209.GJ4489@pasky.or.cz>
Petr Baudis <pasky@suse.cz> writes:
Show 15 quoted lines
> On Fri, Apr 27, 2007 at 06:43:53PM CEST, Petr Baudis wrote:
>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
>> index b67ce41..b51103e 100755
>> --- a/gitweb/gitweb.perl
>> +++ b/gitweb/gitweb.perl
>> @@ -1057,6 +1058,7 @@ sub git_get_project_description {
>>  	open my $fd, "$projectroot/$path/description" or return undef;
>>  	my $descr = <$fd>;
>>  	close $fd;
>> +	$descr or return undef;
>>  	chomp $descr;
>>  	return $descr;
>>  }
>
> It looks like this hunk has been skipped...?

It is more like the whole messages was missed, and then 198a2a8a and others tried to do the same thing but missed this one.

Previous: Petr BaudisNext: Petr Baudis
Message 4 of 5 in “gitweb: Fix few 'use of undefined value' warnings”
  1. gitweb: Fix few 'use of undefined value' warningsPetr Baudis, Apr 27, 2007
  2. Junio C HamanoApr 29, 2007
  3. Petr BaudisMay 17, 2007
  4. Junio C HamanoMay 17, 2007
  5. Petr BaudisMay 17, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.