Re: [PATCH 1/1] Add --first-parent support to interactive rebase.

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 1, 2007, 04:10 UTC
Message-ID: <7vabpyfvwp.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071101032303.GA14495@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 14 quoted lines

> On Wed, Oct 31, 2007 at 03:31:20PM -0700, Junio C Hamano wrote:
>
>> > ... I had one concern that
>> > I was tracking down: is the author name encoding necessarily the same as
>> > the commit text encoding?
>> 
>> The user is screwing himself already if that is the case and
>> uses -s to format-patch, isn't he?
>
> Hrm, they probably _should_ be the same in the output. It's not clear to
> me what encoding we assume the name comes in (utf-8, I guess). Looks
> like we don't touch it at all when putting it in the signoff. I think we
> should just be able to reencode when appending the signoff; patch is
> below.

I think assuming utf-8 and reencoding is actively wrong. Existing setups of people with names that cannot be expressed in ASCII would already have the commit encoding specified in the configuration and user.name stored in that encoding, so passing things through as we have always done is the right thing to do.