Re: I'm a total push-over..
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 23, 2008, 02:23 UTC
- Message-ID
- <7vabmxqnz8.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <alpine.LFD.1.00.0801221515350.1741@woody.linux-foundation.org>
Linus Torvalds <torvalds@linux-foundation.org> writes:
> Ok, here's an interesting patch based on the current 'next' (since it very > intimately requires the new in-memory index format).
This is nice. It does not do anything specific with HFS+ issues but aims for faster look-ups, which would help everybody.
Two things I noticed (only two, not necessarily because you are good but mostly because I am still mired in day job and could not get enough uninterrupted minutes to read the patch ;-)):
- You might want to store the hash table (once computed) in the index extension section, and lazily unpack the table the first time index_name_exists() or set_index_entry() is called on the given istate, instead of unpacking it immediately when you read from the disk. That way, ls-files does not have to suffer at all.
- You would need to get rid of the table in discard_index().