Re: [PATCH] pack-objects: Print a message describing the number of threads for packing
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 26, 2008, 09:19 UTC
- Message-ID
- <7vablo848d.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20080226080634.GA4129@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 14 quoted lines
> On Tue, Feb 26, 2008 at 12:00:05AM -0800, Junio C Hamano wrote: > >> >> + if (progress) >> >> + fprintf(stderr, "Using %d pack threads.\n", >> >> + delta_search_threads); >> > >> > I just noticed that this was in next. >> >> Please send in a fix-up patch to remove it. I noticed it while >> reviewing the patch, and even commented on it, but I somehow >> forgot that this leftover debugging message disqualified the >> series from 'next' when I was merging topics to 'next'. > > Are you sure you are thinking of the same message?
Ah, no.
But now you mention it, I tend to agree with you. This is primarily of interest for git developers and I do not think the end users would care. Maybe under --verbose or --debug option (but I do not think we have --debug option anywhere).