git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] index-pack: allocate NUL byte at the buffer end

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 2, 2008, 01:06 UTC
Message-ID
<7vablix7ch.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<12044064822655-git-send-email-mkoegler@auto.tuwien.ac.at>
Martin Koegler <mkoegler@auto.tuwien.ac.at> writes:
> Signed-off-by: Martin Koegler <mkoegler@auto.tuwien.ac.at>
> ---
> Other parts of git add a NUL to buffers as safty measure, so why not index-pack/
> unpack-objects too?

Perhaps because nobody other than index-pack itself accesses it as if it is a NUL terminated buffer?

Previous: Martin Koegler
Message 3 of 3 in “index-pack: allocate NUL byte at the buffer end”
  1. 1/2 index-pack: allocate NUL byte at the buffer endMartin Koegler, Mar 1, 2008
  2. 2/2 unpack-objects: allocate NUL byte at the buffer endMartin Koegler, Mar 1, 2008
  3. Junio C HamanoMar 2, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.