git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Allow cherry-pick (and revert) to add signoff line

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 23, 2008, 05:08 UTC
Message-ID
<7vabjlupjc.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1208714585-4053-1-git-send-email-dpmcgee@gmail.com>
Dan McGee <dpmcgee@gmail.com> writes:
Show 13 quoted lines
> I often find myself pulling patches off of other peoples trees using
> cherry-pick, and following it with an immediate 'git commit --amend -s'
> command. Eliminate the need for a double commit by allowing signoff on a
> cherry-pick or revert.
>
> Signed-off-by: Dan McGee <dpmcgee@gmail.com>
> ---
>
> This is something I have done in my workflow for a long time, and it seems
> like a weird omission to me. Signoffs can be done on git-am without having
> a second commit, and I often have a workflow where I am picking patches from
> other users' topic branches and have reviewed the patch and would like to
> signoff when I pull it into my tree.

Yeah, when your workflow is heavily rely on cherry-picking, I can see how this would be handy.

I see there was some improvement suggestion suggested on the list, so I will wait until the dust settles and I see an appliable final submission.

Thanks.
Previous: Björn SteinbrinkNext: Dan McGee
Message 3 of 7 in “Allow cherry-pick (and revert) to add signoff line”
  1. Allow cherry-pick (and revert) to add signoff lineDan McGee, Apr 20, 2008
  2. Björn SteinbrinkApr 20, 2008
  3. Junio C HamanoApr 23, 2008
  4. Allow cherry-pick (and revert) to add signoff lineDan McGee, Apr 26, 2008
  5. Allow cherry-pick (and revert) to add signoff lineDan McGee, Apr 26, 2008
  6. Junio C HamanoApr 26, 2008
  7. Remove 'header' from --signoff option descriptionDan McGee, Apr 27, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.