Re: [PATCH, RFC] diff: add option to show context between close chunks
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 20, 2008, 23:43 UTC
- Message-ID
- <7vabcy3k9l.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <48FB757B.9030105@lsrfire.ath.cx>
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
> I think it makes sense to make 1, or even 3, the default for this > option for all commands that create patches intended for human > consumption. The patch keeps the default at 0, though.
I think defaulting to 1 would make sense, or alternatively, just hardcoding that behaviour without any new option. That would give you more information with the same number of patch lines, iow, upside without any downside.
diff --git a/xdiff/xemit.c b/xdiff/xemit.c index d3d9c84..3bf2581 100644 --- a/xdiff/xemit.c +++ b/xdiff/xemit.c @@ -60,9 +60,9 @@ static int xdl_emit_record(xdfile_t *xdf, */ static xdchange_t *xdl_get_hunk(xdchange_t *xscr, xdemitconf_t const *xecfg) { xdchange_t *xch, *xchp; for (xchp = xscr, xch = xscr->next; xch; xchp = xch, xch = xch->next) - if (xch->i1 - (xchp->i1 + xchp->chg1) > 2 * xecfg->ctxlen) + if (xch->i1 - (xchp->i1 + xchp->chg1) > 2 * xecfg->ctxlen + 1) break; return xchp;