Re: [PATCH] Documentation/gitcli.txt: dashed forms not allowed anymore
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 1, 2009, 21:00 UTC
- Message-ID
- <7vabaaivwo.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20090101144045.GC21154@genesis.frugalware.org>
Miklos Vajna <vmiklos@frugalware.org> writes:
Show 8 quoted lines
> On Thu, Jan 01, 2009 at 12:39:39PM +0800, jidanni@jidanni.org wrote: >> - * it's preferred to use the non dashed form of git commands, which means that >> - you should prefer `"git foo"` to `"git-foo"`. >> + * it's required to use the non dashed form of git commands, which means that >> + you must use `"git foo"` and not `"git-foo"`. The latter no longer works. > > I would append: "unless you add the output of `git --exec-path` to your > PATH."
I actually wouldn't.
There needs to be a description about use of PATH=$(git --exec-path):$PATH if you choose to use the dashed forms in your script. Don't we already have that elsewhere more basic in the documentation set?
The quoted part of the documentation talks about the syntax and convention used while scripting, and what it wants to say with the sentence is that the dashless form is preferred, even with PATH=$(git --exec-path):$PATH (iow, it was preferred before 1.6.0, and it still is preferred with the $PATH adjustments after 1.6.0).
I think it muddies the point of the list if you talk about the necessity of $PATH adjustment, which is a irrelevant detail.