Re: [PATCH] import-tars: Allow per-tar author and commit message.

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 24, 2009, 18:54 UTC
Message-ID: <7vab1pf3fj.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.DEB.2.00.0908241659380.16576@perkele.intern.softwolves.pp.se>

Peter Krefting <peter@softwolves.pp.se> writes:

Show 16 quoted lines

> Nanako Shiraishi:
>
>> Instead of requiring the user to have millions of separate files,
>> how about reading a single metainfo file that may look like this?
>
> The advantage of having one (or more) files per tarball is that I can
> use the shell's tab completion to make sure I spell the name of the
> archive correctly. And that it makes it a lot easier to parse.
>
>
> Sam Vilain:
>
>> Also I wonder if there isn't a nicer interface for users.  Why not allow
>> the file to specify From:, Committer: etc as header lines
>
> Good idea.

That sounds like a sensible thing to do.

I however am a bit uneasy to see that the patch didn't seem to (and the rerolled one does not seem to, either) allow any way to forbid reading of the .msg files, other than an obvious workaround of running "find | xargs rm" beforehand. Unlike your "import-directories" that is a brand new program without any existing users, you are touching code that other people have already used, and you do not want to change the behaviour for them only because they happen to have unrelated files in the same directory.