Re: [PATCH 1/2] INSTALL: Update description of our SHA-1 code

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 8, 2009, 20:21 UTC
Message-ID: <7vab15yyqa.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1252425313-69793-1-git-send-email-brian@gernhardtsoftware.com>

Brian Gernhardt <brian@gernhardtsoftware.com> writes:

> We haven't had Mozilla's code or an ARM optimized algorithm since
> 30ae47b.  Reword the paragraph to give credit but not authorship to
> Mozilla.

Thanks.

Show 20 quoted lines

> Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com>
> ---
>
>  Minor nit I noticed while in the INSTALL file.
>
>  INSTALL |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/INSTALL b/INSTALL
> index ae7f750..4a57e47 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -56,8 +56,8 @@ Issues of note:
>  	  library from here.
>  
>  	  If you don't have openssl, you can use one of the SHA1 libraries
> -	  that come with git (git includes the one from Mozilla, and has
> -	  its own PowerPC and ARM optimized ones too - see the Makefile).
> +	  that come with git (git includes one based on Mozilla's as well
> +	  as a PowerPC optimized one - see the Makefile).

The leading comment in block/sha1.c says "initially based on ... although none of the original remains." "one loosely based on" or "one inspired by" might be a more fair statement, although I do not feel too strongly about it.

Show 5 quoted lines

>  
>  	- libcurl library; git-http-fetch and git-fetch use them.  You
>  	  might also want the "curl" executable for debugging purposes.
> -- 
> 1.6.4.2.420.g30ecf