Re: [PATCH 1/1] run-command.c: ignore bad permissions on dirs in PATH
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 25, 2010, 05:34 UTC
- Message-ID
- <7vaarownmv.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <4BFB3C0A.2030505@gmail.com>
Dale Rowley <ddrowley@gmail.com> writes:
Show 10 quoted lines
> All of my git aliases stopped working one day. For example, when I ran 'git ci' > (where 'ci' is an alias for 'commit') it printed out this error: > > fatal: cannot exec 'git-ci': Permission denied > > This error was confusing (I didn't have a 'git-ci' executable anywhere, so why > was it complaining about permissions?) and it took me a while to figure out that > this was happening because I happened to have a random directory in my PATH that > had permissions set incorrectly. Git should probably ignore this, and here is > one way to fix it, although I'm not sure if it's the best way.
As long as the issue is "a directory P on PATH is unreadable, and we tried to see if P/git-ci is executable and reported failure by exiting", I think your patch is a reasonable solution.
Thanks