Re: [PATCH 00/20] [CONTINUE] Add gettext support to Git
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 10, 2010, 16:01 UTC
- Message-ID
- <7vaanpio4n.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <AANLkTimU6Cznnqp+SokZDK7fnhV712a9QcAAd5peo93m@mail.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 13 quoted lines
> Hi, since you didn't pick this up in the last push I fixed it up a bit > more. > > I rebased ab/i18n-all-continue on the new master: > > git fetch git://github.com/avar/git +ab/i18n-all-continue:ab/i18n > > But you probably want this instead: > > git fetch git://github.com/avar/git +ab/i18n-all-continue-with-hindi:ab/i18n > > I took the liberty of adding Ramkumar Ramachandra's hi.po patch to the > series.
I think that the latter is "i18n-continue-with-hindi" (no "all"), and also suspect that ab/i18n-all-continue either hasn't be pushed out or is stale?
The copy of "all-continue" I just fetched ends with 2b5170f (gettextize: git-shortlog basic messages, 2010-09-05) while hindi^ is at c4adf2e (gettextize: git-am printf(1) message to eval_gettext, 2010-09-07).
I haven't formed an opinion as to what to do with the *.po files after the series hits 'next' (or anything more stable than 'pu'); my preference is to delegate that part of the system to somebody who volunteers as an i18n coordinator, and pull from him/her from time to time, just like the way gitk and git-gui are managed.
For now, I'll queue the whole thing and merge that to 'pu', but we would want to squash l10n commits after (but not including) 8d65a35 (gettext tests: test re-encoding with a UTF-8 msgid under Shell, 2010-08-30) that touch only one file in po/*.po into one commit per language, move them near the tip after all the infrastructure enhancements (and fix-ups to the infrastructure, if necessary) and individual command i18ns, to make the end result a reasonably complete and clean "first cut for public testing" of the series before it hits 'next'.
As a companion update to 6495411 (gettext docs: add po/README file documenting Git's gettext, 2010-09-03), we would need a file in Documentation/ directory to describe the use of _() and N_() for programmers and point it from CodingGuidelines. We might also want to move po/README to Documentation/ but I don't have strong preference either way.
Thanks.