Re: [PATCH] commit: Remove backward goto in read_craft_line()

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 1, 2010, 20:19 UTC
Message-ID: <7vaakputxs.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20101201194441.GB27347@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 10 quoted lines

>> @@ -155,6 +151,11 @@ struct commit_graft *read_graft_line(char *buf, int len)
>>  			goto bad_graft_data;
>>  	}
>>  	return graft;
>> +
>> +bad_graft_data:
>> +	error("bad graft data: %s", buf);
>
> A space before the "bad_graft_data:" label would improve future
> diff --show-c-function output.

Hmm, I actually do not think we encourage that (nor we should).

    $ git grep -e '^ [a-z0-9]*:' -- '*.c' | wc -l
    23
    $ git grep -e '^[a-z0-9]*:' -- '*.c' | wc -l
    42

If "--show-c-function" output is the problem, perhaps we should know a bit better about what C function header looks like?