Re: cmd_cherry in builtin/log.c?

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 7, 2010, 20:30 UTC
Message-ID: <7vaakhpbq2.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4CFE83A2.8070004@lsrfire.ath.cx>

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

Show 14 quoted lines

> Am 07.12.2010 18:39, schrieb Jonathan Nieder:
>> while the core of the builtin version is
>> 
>> 	get_patch_ids(&revs, &patch_id_opts, prefix);
>> 
>> The latter function is static, introduced by v1.4.1~12^2~5
>> (format-patch: introduce "--ignore-if-in-upstream", 2006-06-25).
>> 
>> So the answer is that "git cherry" is considered a variant on
>> "git log" (like format-patch, show, and whatchanged) and that it uses
>> "git log" internals.
>
> That's right.  get_patch_ids() could be moved into patch-ids.c now and
> then cmd_cherry() could get its own file in builtin/, though.

Right, but the key word is "could". Is it hurting _anything_ to have it in the current place? I doubt it.