Re: [PATCH 2/2] gitweb: introduce localtime feature

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 17, 2011, 18:26 UTC
Message-ID: <7vaagt4n9f.fsf@alter.siamese.dyndns.org>
In-Reply-To: <m3d3lq57vw.fsf@localhost.localdomain>

Jakub Narebski <jnareb@gmail.com> writes:

Show 11 quoted lines

> Kevin Cernekee <cernekee@gmail.com> writes:
>
>> With this feature enabled, all timestamps are shown in the machine's
>> local timezone instead of GMT.
>
> This does not describe why would one want such way of displaying
> timestamps, and which views would be affected.
>
> BTW. should it be timezone of web server (machine where gitweb is
> run), or local time of author / committer / tagger as described in the
> timezone part of git timestamp?

Both are sensible choices; another plausible choice that normal people would want to see is to use the zone of whoever is requesting the page (note that this would affect the caching layer).

Show 7 quoted lines

>> +	# Use localtime rather than GMT for all timestamps.  Disabled
>> +	# by default.  Project specific override is not supported.
>> +	'localtime' => {
>> +		'override' => 0,
>> +		'default' => [0]},
>
> Why project specific override is not supported?

Good question.