git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sparse: Fix errors and silence warnings

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 3, 2011, 08:17 UTC
Message-ID
<7vaag7g34l.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1301814414-11368-1-git-send-email-bebarino@gmail.com>
Stephen Boyd <bebarino@gmail.com> writes:
Show 12 quoted lines
>  * load_file() returns a void pointer but is using 0 for the return
>    value
>
>  * builtin/receive-pack.c forgot to include builtin.h
>
>  * packet_trace_prefix can be marked static
>
>  * ll_merge takes a pointer for its last argument, not an int
>
>  * crc32 expects a pointer as the second argument but Z_NULL is defined
>    to be 0 (see 38f4d13 sparse fix: Using plain integer as NULL pointer,
>    2006-11-18 for more info)

I think these were originally coded this way to match the way the upstream zlib.h from which we use the function expects us to. But I tend to agree that we should ignore Z_NULL and use NULL throughout the system.

The patch looked fine.  Thanks.
Previous: Stephen Boyd
Message 2 of 2 in “sparse: Fix errors and silence warnings”
  1. sparse: Fix errors and silence warningsStephen Boyd, Apr 3, 2011
  2. Junio C HamanoApr 3, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.