Re: [PATCH] Makefile: add Minix configuration options.

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 19, 2011, 21:39 UTC
Message-ID: <7vaaca7xx9.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110719162659.81020d7c.tcort@minix3.org>

Thomas Cort <tcort@minix3.org> writes:

>  * Adds a $(uname_S) case for Minix with the correct options.

Ok, but lose the asterisk and speak as if you are giving an order to the codebase or the person who maintains it, i.e. "Add $(uname_S) case...".

>  * Adds NEEDS_SSL_WITH_CURL and NEEDS_CRYPTO_WITH_SSL to the
>    libcurl section. On Minix both -lssl and -lcrypto are
>    needed when using -lcurl.

These...

> +	NEEDS_IDN_WITH_CURL = YesPlease
> +	NEEDS_SSL_WITH_CURL = YesPlease

... are not described in the beginning of Makefile; add them.

>  * Changes OPENSSL_LINK to OPENSSL_LIBSSL in the
>    NEEDS_CRYPTO_WITH_SSL conditional in the libopenssl section.

Why is this change necessary?

>    The -lcrypto needs to be in OPENSSL_LIBSSL.

Ditto.

Thanks.