Re: [REGRESSION, BISECTED] `git checkout <branch>` started to be memory hog
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 22, 2011, 20:26 UTC
- Message-ID
- <7vaac6ysd2.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20110722173601.GA9422@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> Did you want me to write a commit message? I think you might do a better > job of writing a coherent one for this particular patch.
I didn't do a very good job.
commit 06a21454b424d5bc0a36ed76ce46bb16ed156774 Author: Jeff King <peff@peff.net> Date: Fri Jul 22 11:00:03 2011 -0600
streaming: free git_istream upon closing
Kirill Smelkov noticed that post 1.7.6 "git checkout" started leaking
tons of memory. close_istream() forgot to release its buffer and the
caller was not freeing it, either.
Signed-off-by: Junio C Hamano <gitster@pobox.com>At least it needs your S-o-b ;-).