Re: [PATCH] gitk: Show patch for initial commit

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 1, 2011, 20:20 UTC
Message-ID: <7vaa9kmpk3.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20111001184216.GA5796@kennedy.acc.umu.se>

Marcus Karlsson <mk@acc.umu.se> writes:

Show 19 quoted lines

>> >diff --git a/gitk-git/gitk b/gitk-git/gitk
>> >index 4cde0c4..20aeae6 100755
>> >--- a/gitk-git/gitk
>> >+++ b/gitk-git/gitk
>> >@@ -7436,7 +7436,7 @@ proc diffcmd {ids flags} {
>> >  	    lappend cmd HEAD
>> >  	}
>> >      } else {
>> >-	set cmd [concat | git diff-tree -r $flags $ids]
>> >+	set cmd [concat | git diff-tree -r --root $flags $ids]
>> >      }
>> >      return $cmd
>> >  }
>> Cool, this works for me! But I think I would be really nice if gitk
>> respected the configuration value of log.showroot. This would give
>> nice consistency amongst the various tools.
>
> I agree, that would be reasonable. I'll prepare a new patch with that
> behavior.

That would be good, but whatever you do please keep the maintainer of gitk, Paul Mackerras <paulus@samba.org>, in the loop.