Re: [PATCH 3/4] fetch-pack: match refs exactly

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 15, 2011, 21:46 UTC
Message-ID: <7vaa6tmrtd.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20111213004808.GC3699@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 10 quoted lines

> This is obviously the one that can break existing fetch-pack users. I
> doubt they exist. If they do, there are a few alternatives:
>
>   1. Come up with some more sane rules for path_match (e.g., try full
>      strings first, use full-string matching for things starting with
>      "refs/", etc).
>
>   2. Leave the matching in-place for git-fetch-pack, but use exact
>      matching for internal users that will always provide qualified refs
>      (i.e., "git fetch").

I think the latter is the sane thing to do _if_ this becomes an issue, and as you mention, it is in line with what "git fetch" wrapper already does.

Given that fetch-pack was meant to be driven by "git fetch" wrapper that turns the command line and other refspecs into full refnames on the remote end before calling it, and also as you mentionied that it is clearly documented as "relative to $GIT_DIR", I do not think we should support the tail-match semantics at all in the first place.