Re: [PATCH] log-tree: use custom line terminator in line termination mode
Jan Krüger <jk@jk.gs> writes:
Show 24 quoted lines
> When using a custom format in line termination mode (as opposed to line
> separation mode), the configured line terminator is not used, so things
> like "git log --pretty=tformat:%H -z" do not work properly.
>
> Make it use the line terminator the user ordered.
>
> Signed-off-by: Jan Krüger <jk@jk.gs>
> ---
> log-tree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/log-tree.c b/log-tree.c
> index 34c49e7..44f0268 100644
> --- a/log-tree.c
> +++ b/log-tree.c
> @@ -682,7 +682,7 @@ void show_log(struct rev_info *opt)
> if (opt->use_terminator) {
> if (!opt->missing_newline)
> graph_show_padding(opt->graph);
> - putchar('\n');
> + putchar(opt->diffopt.line_termination);
> }
>
> strbuf_release(&msgbuf);Looks sensible. Perhaps we would want to add a test?