Re: [PATCH] Build in gettext poison feature unconditionally

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 21, 2012, 16:37 UTC
Message-ID: <7va9xofbgo.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120821052404.GB55686@mannheim-rule.local>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 13 quoted lines

> Nguyễn Thái Ngọc Duy wrote:
>
>> The runtime cost should be small. "gcc -O2" inlines _() and
>> use_gettext_poison(). But even if it does not, performance should not
>> be impacted as _() calls are usually not on critical path. If some of
>> them are, we better fix there as gettext() may or may not be cheap
>> anyway.
>
> That seems reasonable to me.  The increase in code size of a commonly
> inlined function and the extra "if" in a common if not
> performance-critical codepath is annoying (and I'd prefer to keep
> use_gettext_poison() un-inlined), but in any event the cost would go
> away once the translation-based implementation of poison lands.

I would say it is not worse than just "annoying"; if the cost will go away, I'd rather see this conversion postponed and is done as part of (and preferrably at the end of) the "poison with a poison-locale" series.

> Yes, that would be nice (or perhaps a mode to run most tests in
> the current locale and rerun test assertions that use a test_i18n*
> helper or C_LOCALE_OUTPUT prerequisite in the C locale).

Yeah, I think that is the right direction to go; I suspect that "poison with a poison-locale" would have to be ready to allow us to go there, though.